Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in #js reader tag #449

Closed
mk opened this issue Nov 25, 2020 · 3 comments
Closed

Bug in #js reader tag #449

mk opened this issue Nov 25, 2020 · 3 comments

Comments

@mk
Copy link
Collaborator

mk commented Nov 25, 2020 •
edited
Loading

version
0.1.1-alpha.9
platform

JavaScript
problem
#js [1] evaluated in sci returns a map wrapped in a vector:

CleanShot 2020-11-25 at 10 49 44@2x

repro

(sci/eval-string "#js[1]")

expected behavior

(sci/eval-string "(= (clj->js [1]) #js[1])")

should evaluate to true
@borkdude
Copy link
Collaborator

@mk Note that

cljs.user=> (= (clj->js [1]) #js[1])
false

because this is JavaScript :)

@borkdude borkdude mentioned this issue Nov 25, 2020
Closed
@mk
Copy link
Collaborator Author

mk commented Nov 25, 2020

@borkdude oops, good point!

borkdude added a commit that referenced this issue Nov 25, 2020
@borkdude
[#449] Fix #js object reading
c21d6f2
@borkdude
Copy link
Collaborator

Fixed:

Screenshot 2020-11-25 at 12 06 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mk @borkdude