Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle plugin and preset options #39

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Handle plugin and preset options #39

merged 1 commit into from
Aug 17, 2016

Conversation

razor-x
Copy link
Contributor

@razor-x razor-x commented Aug 17, 2016

Fixes #37

@paulmillr
Copy link
Contributor

Looks good. Could you check what's up with the failing tests?

@razor-x
Copy link
Contributor Author

razor-x commented Aug 17, 2016

Sure, looks like an issue on node 4 only. The way the test suite is written it swallows exceptions, so I'll try to work out what's breaking,

@razor-x
Copy link
Contributor Author

razor-x commented Aug 17, 2016

Working now: needed to explicitly add the extra plugin to devDependencies (since npm 2 doesn't flatten).

@paulmillr paulmillr merged commit 5f9e6c3 into babel:master Aug 17, 2016
@paulmillr
Copy link
Contributor

Thank you! I'm going to publish the new version later tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@razor-x @paulmillr