Fix bugs when using .babelrc, and babel option in package.json #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
suggested changes
Dec 27, 2016
| @@ -83,5 +106,6 @@ class BabelCompiler { | |||
| BabelCompiler.prototype.brunchPlugin = true; | |||
| BabelCompiler.prototype.type = 'javascript'; | |||
| BabelCompiler.prototype.extension = 'js'; | |||
There was a problem hiding this comment.
pattern has precedence over extension. Let's remove extension
| logger.warn(`${warning}`); | ||
| } | ||
| }; | ||
|
|
||
| class BabelCompiler { | ||
| constructor(config) { | ||
| if (!config) config = {}; |
There was a problem hiding this comment.
Let's remove this line.
| logger.warn(`${warning}`); | ||
| } | ||
| }; | ||
|
|
||
| class BabelCompiler { | ||
| constructor(config) { | ||
| if (!config) config = {}; | ||
| const options = config.plugins && |
There was a problem hiding this comment.
const options = config.plugins.babel || config.plugins.ES6to5 || {}; while we at it
| @@ -15,20 +20,39 @@ const prettySyntaxError = (err) => { | |||
| } | |||
| }; | |||
|
|
|||
| const warnIf = (condition, warning) => { | |||
There was a problem hiding this comment.
Let's drop this helper.
| opts.sourceMap = !!config.sourceMaps; | ||
| if (!opts.presets) opts.presets = ['es2015', 'es2016']; | ||
| if (!opts.presets || opts.presets.length === 0) { | ||
| if (!config.lookupConfigs) { |
There was a problem hiding this comment.
Let's check babelrc, package.json's babel field and lastly, dependencies and devDependencies of package.json
Merged
|
I believe this was superseded by #49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix 2 issues:
brunch-configfile or just set it as an empty array, babel-brunch will automatically set es2015, es2016 presets. It causes conflicts if you keep your babel config in .babelrc orbabeloption in package.json file.Proposed solution:
js/jsx/es6pattern static.config.lookupConfigs = trueto prevent crashes . It would add the ability to use people babelrc and package.json configs, but must prevent other users' incomprehension.lookupConfigsoption - warn them to add presets they need.ES6to5option and to change it tobabel.So after these changes, we will protect users from crashes and at the same time add the ability to use babelrc + pckg.json configuration normally by providing
lookupConfigsoption.