Raise error for rest parameters

babel · Apr 11, 2021 · 6a0c387 · 6a0c387
1 parent f81ff17
commit 6a0c387
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 0 deletions.
diff --git a/packages/babel-parser/src/plugins/typescript/index.js b/packages/babel-parser/src/plugins/typescript/index.js
@@ -126,6 +126,8 @@ const TSErrors = makeErrorTemplates(
       "'readonly' modifier can only appear on a property declaration or index signature.",
     SetAccesorCannotHaveOptionalParameter:
       "A 'set' accessor cannot have an optional parameter.",
+    SetAccesorCannotHaveRestParameter:
+      "A 'set' accessor cannot have rest parameter.",
     SetAccesorCannotHaveReturnType:
       "A 'set' accessor cannot have a return type annotation.",
     TypeAnnotationAfterAssign:
@@ -647,6 +649,12 @@ export default (superClass: Class<Parser>): Class<Parser> =>
                 TSErrors.SetAccesorCannotHaveOptionalParameter,
               );
             }
+            if (firstParameter.type === "RestElement") {
+              this.raise(
+                this.state.pos,
+                TSErrors.SetAccesorCannotHaveRestParameter,
+              );
+            }
           }
           if (method.typeAnnotation) {
             this.raise(

diff --git a/.../babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/input.ts b/.../babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/input.ts
@@ -0,0 +1,3 @@
+interface Foo {
+  set bar(...v);
+}
diff --git a/...bel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/output.json b/...bel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/output.json
@@ -0,0 +1,53 @@
+{
+  "type": "File",
+  "start":0,"end":34,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":1}},
+  "errors": [
+    "SyntaxError: A 'set' accessor cannot have rest parameter. (3:1)"
+  ],
+  "program": {
+    "type": "Program",
+    "start":0,"end":34,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":1}},
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "TSInterfaceDeclaration",
+        "start":0,"end":34,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":1}},
+        "id": {
+          "type": "Identifier",
+          "start":10,"end":13,"loc":{"start":{"line":1,"column":10},"end":{"line":1,"column":13},"identifierName":"Foo"},
+          "name": "Foo"
+        },
+        "body": {
+          "type": "TSInterfaceBody",
+          "start":14,"end":34,"loc":{"start":{"line":1,"column":14},"end":{"line":3,"column":1}},
+          "body": [
+            {
+              "type": "TSMethodSignature",
+              "start":18,"end":32,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":16}},
+              "key": {
+                "type": "Identifier",
+                "start":22,"end":25,"loc":{"start":{"line":2,"column":6},"end":{"line":2,"column":9},"identifierName":"bar"},
+                "name": "bar"
+              },
+              "computed": false,
+              "kind": "set",
+              "parameters": [
+                {
+                  "type": "RestElement",
+                  "start":26,"end":30,"loc":{"start":{"line":2,"column":10},"end":{"line":2,"column":14}},
+                  "argument": {
+                    "type": "Identifier",
+                    "start":29,"end":30,"loc":{"start":{"line":2,"column":13},"end":{"line":2,"column":14},"identifierName":"v"},
+                    "name": "v"
+                  }
+                }
+              ]
+            }
+          ]
+        }
+      }
+    ],
+    "directives": []
+  }
+}