-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Respect
package.json#exports
when resolving plugins (#14110)
* Respect `package.json#exports` when resolving plugins * Use native import.meta.resolve when available * Workaround V8 bug that makes Babel-Jest segfault.
- Loading branch information
1 parent
693f2d2
commit e7c705a
Showing
16 changed files
with
282 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
packages/babel-core/src/config/files/import-meta-resolve.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { createRequire } from "module"; | ||
import { resolve as polyfill } from "../../vendor/import-meta-resolve"; | ||
|
||
const require = createRequire(import.meta.url); | ||
|
||
let import_; | ||
try { | ||
// Node < 13.3 doesn't support import() syntax. | ||
import_ = require("./import").default; | ||
} catch {} | ||
|
||
// import.meta.resolve is only available in ESM, but this file is compiled to CJS. | ||
// We can extract ir using dynamic import. | ||
const resolveP = | ||
import_ && | ||
// Due to a Node.js/V8 bug (https://github.com/nodejs/node/issues/35889), we cannot | ||
// use dynamic import when running in the default Jest environment because it | ||
// uses vm.SourceTextModule. | ||
// Jest defines globalThis["jest-symbol-do-not-touch"] in | ||
// https://github.com/facebook/jest/blob/11d79ec096a25851124356095d60352f6ca2824e/packages/jest-util/src/installCommonGlobals.ts#L49 | ||
// which is called by | ||
// https://github.com/facebook/jest/blob/11d79ec096a25851124356095d60352f6ca2824e/packages/jest-environment-node/src/index.ts#L85 | ||
// | ||
// Note that our Jest runner doesn't have this problem, because it runs ESM in the default | ||
// Node.js context rather than using the `vm` module. | ||
// | ||
// When V8 fixes this bug, we can remove this check. We usually don't have package-specific hacks, | ||
// but Jest is a big Babel consumer widely used in the community and they cannot workaround | ||
// this problem on their side. | ||
!Object.hasOwnProperty.call(global, "jest-symbol-do-not-touch") | ||
? import_("data:text/javascript,export default import.meta.resolve").then( | ||
// Since import.meta.resolve is unstable and only available when | ||
// using the --experimental-import-meta-resolve flag, we almost | ||
// always use the polyfill for now. | ||
m => m.default || polyfill, | ||
() => polyfill, | ||
) | ||
: Promise.resolve(polyfill); | ||
|
||
export default function getImportMetaResolve(): Promise<ImportMeta["resolve"]> { | ||
return resolveP; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export function resolve(specifier: stirng, parent: string): Promise<string>; |
9 changes: 9 additions & 0 deletions
9
...babel-core/test/fixtures/resolution/pkg-exports/node_modules/babel-plugin-dual/import.mjs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.