New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable logical assignment by default in @babel/parser #11860
Comments
Hey @JLHwung! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly. If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite." |
I would like to give it a try |
@pustovalov Thanks for showing up. A good first issue targets to first-time contributors. That said, if it is not claimed by a new contributor in the next 24 hours, it will be yours! |
I would like to take this. Will have it ready within 24 hours if that works. |
@vahnag It's yours! |
@vahnag no rush! |
Feature Request
Logical Assignment (
&&=
,||=
,??=
) is Stage 4!This means that it should be enabled by default in
@babel/parser
🎉It should be done similarly to this commit: c3388ea
this.hasPlugin
andthis.expectPlugin
checks related tologicalAssignment
inpackages/babel-parser/src
logicalAssignment
in@babel/parser
's testsexperimental
folder toes2021
, create one if it doesn't existIf it is the first time that you contribute to Babel, follow these steps: (you need to have
make
andyarn
available on your machine)git clone https://github.com/<YOUR_USERNAME>/babel.git && cd babel
yarn && make bootstrap
make watch
(ormake build
whenever you change a file)input.js
;output.js
will be automatically generated)yarn jest babel-parser
to run the testsoutput.js
files and run the tests againOVERWRITE=true yarn jest babel-parser
and they will be automatically updated.yarn jest
to run all the testsgit push
and open a PR!The text was updated successfully, but these errors were encountered: