Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable logical assignment by default in @babel/parser (#11860) #11869

Merged
merged 1 commit into from Jul 22, 2020
Merged

Enable logical assignment by default in @babel/parser (#11860) #11869

merged 1 commit into from Jul 22, 2020

Conversation

vahnag
Copy link
Contributor

@vahnag vahnag commented Jul 22, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #11860
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes? N
License MIT
  • Removed expectPlugin calls
  • Removed test checking if plugin is enabled
  • Moved tests to es2021 directory
  • Updated a test in babel-core to not use logical assignment for checking unavailable plugin error messages

@JLHwung JLHwung changed the base branch from main to feat-7.11.0/stage-4 July 22, 2020 14:08
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48b98ab:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26323/

JLHwung
JLHwung approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung mentioned this pull request Jul 22, 2020
Merged
5 tasks
hzoo
hzoo approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@JLHwung JLHwung merged commit e134414 into babel:feat-7.11.0/stage-4 Jul 22, 2020
JLHwung pushed a commit that referenced this pull request Jul 29, 2020
@vahnag @JLHwung
Enable logical assignment by default in @babel/parser (#11860) (#11869)
b651a6f
@sosukesuzuki sosukesuzuki mentioned this pull request Oct 9, 2020
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@hzoo hzoo hzoo approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable logical assignment by default in @babel/parser
5 participants
@vahnag @babel-bot @existentialism @hzoo @JLHwung