Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class fields should be configurable:true #6108

Closed
8 tasks
loganfsmyth opened this issue Aug 15, 2017 · 4 comments
Closed
8 tasks

Class fields should be configurable:true #6108

loganfsmyth opened this issue Aug 15, 2017 · 4 comments
Labels
claimed good first issue outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@loganfsmyth
Copy link
Member

loganfsmyth commented Aug 15, 2017

Spec updated: tc39/proposal-class-fields#35

It defaults to false in Babel here: https://github.com/babel/babel/blob/7.0/packages/babel-plugin-transform-class-properties/src/index.js#L28 We should add configurable: true to that config.

    Object.defineProperty(REF, KEY, {
      // configurable is false by default
      enumerable: true,
      writable: true,
      value: VALUE
    });

We'd ask that if you've already made a PR you'd let someone new take this 😄 , thanks!

@reznord
Copy link
Contributor

reznord commented Aug 15, 2017

I'd love to take this issue if no one has grabbed it yet.

@existentialism
Copy link
Member

@reznord go for it!

@littledan
Copy link

Thanks for picking this up, and sorry about my typo!

@reznord
Copy link
Contributor

reznord commented Aug 16, 2017

That's real quick 😅

@hzoo hzoo mentioned this issue Sep 12, 2017
10 tasks
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
claimed good first issue outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

4 participants