Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'configurable' property to class fields #6123

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Add 'configurable' property to class fields #6123

merged 1 commit into from
Aug 16, 2017

Conversation

reznord
Copy link
Contributor

@reznord reznord commented Aug 16, 2017

Q                       A
Fixed Issues Fixes #6108
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added/Pass? Yes
Spec Compliancy? No
License MIT
Doc PR
Any Dependency Changes? No

Adds configurable: true key here: https://github.com/babel/babel/blob/7.0/packages/babel-plugin-transform-class-properties/src/index.js#L27

    Object.defineProperty(REF, KEY, {
      configurable: true,
      enumerable: true,
      writable: true,
      value: VALUE
    });

The below are the checklist mentioned in the issue:

  • Comment below you are going to do this (for others to know)
  • Read CONTRIBUTING.md
  • Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • Join our slack if you haven't already if you need more immediate help or just comment in this issue/PR (this might be down, we can add you manually)
  • check the class properties package/folder
  • follow the steps above in changing the behavior
  • fix tests
  • update the readme if necessary

@mention-bot
Copy link

@reznord, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @existentialism and @hzoo to be potential reviewers.

@xtuc xtuc added pkg: class-properties PR: Spec Compliance 👓 A type of pull request used for our changelog categories labels Aug 16, 2017
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice first contribution 👍

@reznord
Copy link
Contributor Author

reznord commented Aug 16, 2017

There are a few tests that are left behind (7 tests) when I ran make test.

Any idea why that is happening? And the code-coverage also shows 86%. Is it normal?

Thanks @xtuc 😄

@hzoo hzoo merged commit 6ab3b4c into babel:7.0 Aug 16, 2017
@reznord reznord deleted the add-configurable-transform-class-properties branch August 16, 2017 14:15
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants