Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround #10179 in proposal-object-rest-spread #10200

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 11, 2019

Q                       A
Fixed Issues? Fixes #10179
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The real cause of this bug is in @babel/core (#10187), but even if we fixed it new versions of plugin-proposal-object-rest-spread wouldn't work with older versions of @babel/core and @babel/helpers.
This bug also needs to be fixed in @babel/core anyway, otherwise it will happen again.

I couldn't figure out how to add a test for this bug; I tested it manually with a package.json like this (it requires yarn):

{
  "devDependencies": {
    "@babel/cli": "^7.5.0",
    "@babel/core": "7.4.0",
    "@babel/plugin-proposal-object-rest-spread": "file:../../babel/babel/packages/babel-plugin-proposal-object-rest-spread"
  },
  "resolutions": {
    "@babel/helpers": "7.4.0"
  }
}
Input
void { ...foo };
void { ...bar };
Output before the fix
function _objectSpread2(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; var ownKeys = Object.keys(source); if (typeof Object.getOwnPropertySymbols === 'function') { ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) { return Object.getOwnPropertyDescriptor(source, sym).enumerable; })); } ownKeys.forEach(function (key) { _defineProperty(target, key, source[key]); }); } return target; }

function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }

void _objectSpread2({}, foo);
void _objectSpread({}, bar);
Output after the fix
function _objectSpread2(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; var ownKeys = Object.keys(source); if (typeof Object.getOwnPropertySymbols === 'function') { ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) { return Object.getOwnPropertyDescriptor(source, sym).enumerable; })); } ownKeys.forEach(function (key) { _defineProperty(target, key, source[key]); }); } return target; }

function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }

void _objectSpread2({}, foo);
void _objectSpread2({}, bar);

Note that in the fixed output the injected helper is called _objectSpread2 only because Babel is trolling* us, that is the _objectSpread helper present in <7.5.0.

*trolling = In the "try" block it genertes an _objectSpread UUID which is then discarted, so it must create _objectSpread2 the second time.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jul 11, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11109/

@danez
danez approved these changes Jul 13, 2019
Copy link
Contributor

@thiagoarrais thiagoarrais left a comment

Fix confirmed locally.

@nicolo-ribaudo nicolo-ribaudo merged commit 7dc5fdb into babel:master Jul 15, 2019
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 87.56% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:issue-10179 branch Jul 15, 2019
@nicolo-ribaudo
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Jul 15, 2019

Release tomorrow!

AdamRamberg added a commit to AdamRamberg/babel that referenced this pull request Jul 17, 2019
@lock lock bot added the outdated label Oct 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants