Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always throw when add missing helpers #10208

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Jul 12, 2019

Q                       A
Fixed Issues? Fixes #10187
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The problem with current addHelper is that this line will get execute first, before knowing whether the helper existed:

// 2) will short circuit if `this.declarations[name]` exists
const declar = this.declarations[name];
if (declar) return t.cloneNode(declar);

// 1) will set this.declarations[name] no matter helper exists
const uid = (this.declarations[name] = this.scope.generateUidIdentifier(
   name,
));

so i added a helpers.ensure(name) before (1).

Since loadHelper is cached, it's okay to call it multiple times.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jul 12, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11117/

@existentialism existentialism merged commit f5ca058 into babel:master Jul 12, 2019
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 87.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 12, 2019

Related: #10200

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants