Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ";" token to the end of TS construct & call signature declaration #10258

Merged
merged 2 commits into from Jul 25, 2019

Conversation

skyiea
Copy link
Contributor

@skyiea skyiea commented Jul 23, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link --
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 23, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11228/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11222/

@JLHwung
Copy link
Contributor

JLHwung commented Jul 23, 2019

Could you also check if the printer will add ; for the CallSignature?

interface a {
    (a: string) : number
}

Per Object Type Literals Grammar, only the last TypeMember of TypeMemberList can omit trailing semicolon. I suggest we add another TypeMember to the test case so that ; can not be omitted.

interface a {
    new (a: string): void
    new (a: number): void
}

@JLHwung JLHwung added area: typescript pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 23, 2019
@skyiea skyiea changed the title Add ";" token to the end of TS construct signature declaration Add ";" token to the end of TS construct & call signature declaration Jul 24, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 4d30379 into babel:master Jul 25, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants