Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing interface with new in it #59

Closed
BrooklynKing opened this issue Sep 21, 2018 · 2 comments
Closed

Parsing interface with new in it #59

BrooklynKing opened this issue Sep 21, 2018 · 2 comments
Labels
bug Something isn't working okidoc-md

Comments

@BrooklynKing
Copy link
Collaborator

interface IPlaybackAdapterClass {
  new (eventEmitter: IEventEmitter): IPlaybackAdapter;

  isSupported(): boolean;
}

when okidoc trying to parse this construction with babylon(?), it fails with exception

An error occurred while building documentation. { SyntaxError: "Player public methods" documentation source (src/core/default-modules.ts) - Unexpected token (82:2)
  80 | interface IPlaybackAdapterClass {
  81 |   new (eventEmitter: IEventEmitter): IPlaybackAdapter
> 82 |   isSupported(): boolean;
     |  ^
  83 | }
  84 |
  85 | /**

as you can see, there is no ; after line with new. Right now i'm just putting this line as last in interface declaration, so it's not critical for me.

@BrooklynKing BrooklynKing added the bug Something isn't working label Sep 21, 2018
@bodia-uz
Copy link
Collaborator

Thanks for reporting. Will look into it

@skyiea
Copy link
Contributor

skyiea commented Jul 23, 2019

Pending resolution of babel/babel#10258
Then we'll need to update @babel/generator in okidoc-md/package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working okidoc-md
Projects
None yet
Development

No branches or pull requests

3 participants