Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't polyfill when evaluation is not confident #10397

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Don't polyfill when evaluation is not confident #10397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/babel-preset-env/src/polyfills/corejs2/usage-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default function(
if (isNamespaced(path.get("object"))) return;

let evaluatedPropType = object.name;
let propertyName = property.name;
let propertyName = "";
let instanceType = "";

if (node.computed) {
Expand All @@ -119,6 +119,8 @@ export default function(
propertyName = result.value;
}
}
} else {
propertyName = property.name;
}

if (path.scope.getBindingIdentifier(object.name)) {
Expand Down
5 changes: 5 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/usage-evaluated-not-confident/input.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Object['values'](); // include
[]['map'](); // include

Object[keys](); // don't include
[][filter](); // don't include
12 changes: 12 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/usage-evaluated-not-confident/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"presets": [
[
"../../../../lib",
{
"useBuiltIns": "usage",
"corejs": 2,
"modules": false
}
]
]
}
13 changes: 13 additions & 0 deletions packages/babel-preset-env/test/fixtures/corejs2/usage-evaluated-not-confident/output.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import "core-js/modules/es6.array.map";
import "core-js/modules/web.dom.iterable";
import "core-js/modules/es6.array.iterator";
import "core-js/modules/es6.object.to-string";
import "core-js/modules/es7.object.values";
Object['values'](); // include

[]['map'](); // include

Object[keys](); // don't include

[][filter](); // don't include