Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create parser plugin "topLevelAwait" #10449
Create parser plugin "topLevelAwait" #10449
Changes from 5 commits
7c95240
14aa7e4
9a16a3e
94cfa86
be80170
fd83281
b73f31c
c3d892e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If top-level await is only valid in modules, should seeing one set
sawUnambiguousESM
? In other words, how should this behave with asourceType
ofunambiguous
? Currently, parsingawait 0
withunambiguous
yields an AST withsourceType
ofscript
, even though if you'd specifiedscript
it would not have parsed:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tricky because, for exmaple, this is both a valid script and a valid module:
I can set it to a module when
await
the next invalid token is on the same line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I missed
await ` 0 `
.I come up with a new case: If one turns on
v8intrinsic
, the following could be ambiguous, too.