-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/test262 #10500
Ci/test262 #10500
Conversation
|
This introduces a second Circle CI pipeline that can optionally run test262 against babel if the maintainers wish to do it before merging a pull request. Running test262 is expensive so we don't want that to happen for each commit in every PR.
Nice, the test output is not super useful yet but we might be able to do something out of the xunit file for further analysis. |
@rricard yes but I don't want to run test262 twice for master and PR. Ideally we should be able to reuse the build artifact from master to compare and analyse. It already takes 1.5 hours to run the tests once. I am hoping @circleci can highlight new errors from existing errors like Jenkins can simply by giving it an xunit file |
This doesn't get added to babel build somehow, right? Or I need to add it in .npmignore or something? |
No, because it isn't committed to the repo or present in our local copies. |
So I put a support ticket to @circleci and turns out they do not have the Jenkins-style rendering of new vs existing test failures. In the meanwhile, we may have to do this: “ And also, we can store the previous test results data as artifacts and it can download via API, so I think you can also create a script that compares the test results.” For CI, I think if we can highlight if a PR has failed new tests. But in terms of a web UI or anything fancy we should work on getting it added to test262.report |
Fixes #1, Fixes #2