-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dev dependencies #10847
Add missing dev dependencies #10847
Conversation
# Conflicts: # yarn.lock
# Conflicts: # packages/babel-register/package.json # yarn.lock
46e39fe
to
461bd2c
Compare
@kaicataldo Do you have any clue about where the linting errors might come from? |
@nicolo-ribaudo We should map |
package.json
Outdated
@@ -77,7 +78,9 @@ | |||
"typescript": "^3.6.3" | |||
}, | |||
"resolutions": { | |||
"@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates" | |||
"@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates", | |||
"#todo: remove eslint-scope resolution when babel-eslint 11.0.0-beta.2 is published": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, comments aren't supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like comment but semantically it is a long sentence key.
bf97d28
to
d48d9ee
Compare
This PR is extracted from a messy working branch on the upcoming Yarn 2 support: https://github.com/JLHwung/babel/commits/standalone-rollup-bundle
The following devDependencies is required since Yarn 2 does not resolve package in
../../node_modules
, which is the rootnode_modules
in the project.Note that
eslint-import-resolver-node
would not bail on these situations since the Node.js module resolution algorithm will resolve all the way up toGLOBAL_FOLDERS
.