Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemJS top-level await support #12163

Merged
merged 2 commits into from Oct 14, 2020
Merged

SystemJS top-level await support #12163

merged 2 commits into from Oct 14, 2020

Conversation

@guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 11, 2020

Q                       A
Fixed Issues? Fixes #9426
Minor: New Feature? Feature
Tests Added + Pass? Yes
License MIT

Now that Chrome has expressed an intent to ship top-level await, this adds automatic support for this feature to the SystemJS output.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 11, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29861/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6e0ff0:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

I was initially on the fence about this (we don't enable proposals by default), however:

  • Parsing for top-level await is still opt-in
  • If someone enables parsing for TLA, the generated code will be just broken.

Btw, we should also add @babel/plugin-syntax-top-level-await to @babel/preset-env's shippedProposals option (but only enable it when targeting SystemJS maybe?)

@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Oct 12, 2020
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@nicolo-ribaudo nicolo-ribaudo merged commit 9c7d9c0 into babel:main Oct 14, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.75% (target 90.00%)
Details
e2e Workflow: e2e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.