Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Jest to v26 #12190

Merged
merged 2 commits into from Oct 30, 2020
Merged

chore: bump Jest to v26 #12190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36f83bc
chore: bump Jest to v26
JLHwung Oct 15, 2020
be4c26a
bump to Jest 26.6.1
JLHwung Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -117,6 +117,10 @@ jobs:
- name: Install
run: |
BABEL_ENV=test-legacy make -j bootstrap-only
- name: Downgrade Jest for node <= 8
if: matrix.node-version == '6' || matrix.node-version == '8'
run: |
yarn remove jest && yarn add --dev jest@24
- uses: actions/download-artifact@v2
with:
name: babel-artifact
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
"babel-jest": "^24.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove babel-jest because jest-config always load babel-jest and we are not using babel-jest explicitly in jest config.

https://github.com/facebook/jest/blob/e84a70c8456d61daa36b5c79a4df7ee752d6d6d6/packages/jest-config/src/normalize.ts#L241

"babel-plugin-transform-charcodes": "^0.2.0",
"chalk": "^2.4.2",
"charcodes": "^0.2.0",
Expand All @@ -52,7 +51,7 @@
"gulp-newer": "^1.0.0",
"gulp-plumber": "^1.2.1",
"husky": "^3.0.0",
"jest": "^24.9.0",
"jest": "^26.6.1",
"lerna-changelog": "^0.5.0",
"lint-staged": "^9.2.0",
"mergeiterator": "^1.2.5",
Expand Down