-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Jest to v26 #12190
chore: bump Jest to v26 #12190
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31392/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be4c26a:
|
@@ -35,7 +35,6 @@ | |||
"@rollup/plugin-json": "^4.1.0", | |||
"@rollup/plugin-node-resolve": "^9.0.0", | |||
"@rollup/plugin-replace": "^2.3.3", | |||
"babel-jest": "^24.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove babel-jest
because jest-config
always load babel-jest
and we are not using babel-jest
explicitly in jest config.
Is there any advantage in upgrading, since we have to stick to Jest 24 features anyway for compatibility? |
@nicolo-ribaudo This PR is extracted from #11968. Jest 26 supports collecting coverage from v8: So we don't have to rebuild artifacts with Jest 26 should be faster than v24 because it compiles to Node.js 10. I think we could use some Jest 26 features, -- just have to skip the test on Node.js 6 / 8. Generally bumping Jest to v26 also ensure that we have tests running on Jest 26, eventually we will use Jest 26 on Babel 8, we can provide feedback earlier if any regression introduced, otherwise we may come across surprises when bumping Jest on Babel 8 in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like an hack, but given that we are using .mjs
files from some tests I think we should still merge this PR.
For example, it will make tests for #12266 much easier.
This PR bumps Jest to v26. Since v26 drops Node.js 8 support, we downgrade Jest to v24 on Node 6/8 CI.