-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid infinite loops in type inference logic #12390
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33103/ |
@ehoogeveen Can you check if replacing the + const typeAnnotationInferringNodes = new WeakSet();
function _getTypeAnnotation() {
var _inferer;
const node = this.node;
if (!node) {
if (this.key === "init" && this.parentPath.isVariableDeclarator()) {
const declar = this.parentPath.parentPath;
const declarParent = declar.parentPath;
if (declar.key === "left" && declarParent.isForInStatement()) {
return t.stringTypeAnnotation();
}
if (declar.key === "left" && declarParent.isForOfStatement()) {
return t.anyTypeAnnotation();
}
return t.voidTypeAnnotation();
} else {
return;
}
}
if (node.typeAnnotation) {
return node.typeAnnotation;
}
+ if (typeAnnotationInferringNodes.has(node)) {
+ return;
+ }
+ typeAnnotationInferringNodes.add(node);
+
+ try {
let inferer = inferers[node.type];
if (inferer) {
return inferer.call(this, node);
}
inferer = inferers[this.parentPath.type];
if ((_inferer = inferer) == null ? void 0 : _inferer.validParent) {
return this.parentPath.getTypeAnnotation();
}
+ } finally {
+ typeAnnotationInferringNodes.delete(node);
+ }
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(When reviewing, please disable whitespace changes and reload.)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f397dc:
|
@nicolo-ribaudo Yes, I see no more crashes after applying this change :) (in fact with this change a stack limit of 70kB is enough to minify Sortable.js) |
This fix is copied from
babel/packages/babel-traverse/src/path/introspection.js
Lines 363 to 369 in 8f191ea