-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from source-map to source-map-js #12805
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdc8931:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46557/ |
51a9733
to
4e888d5
Compare
Node 6 failed but it's expected because WASM support was introduced in Node 8 |
Unfortunately we cannot drop Node.js 6 until Babel 8 😕 |
@nicolo-ribaudo yep, I know. I also maintain source-map-js which is the fork of source-map, but with algorithmic optimizations. It's 4x faster than source-map@6, but still 2x slower than So I think we need to make a choice :) |
@7rulnik Does source-map-js supports node 6? It makes sense to migrate to it first and the see if other improvements are necessary. |
@TrySound yeah, it should. Will update this PR in few days |
8975b3c
to
ec0f0cf
Compare
Hi @nicolo-ribaudo are you interested in merging this ? @7rulnik can you update the dependency to ^1.0.0 ? |
This will also fix an annoying issue in VS Code. source-map@<0.7.1 has an invalid |
All of the |
@jridgewell yeah. I can update PR if it makes sense and we will merge it |
I made the fork of source-map that introduces sync API, but still uses WASM.
You can compare changes to original versions here