-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tagged template incorrect receiver #13395
Conversation
sag1v
commented
May 29, 2021
•
edited by nicolo-ribaudo
Loading
edited by nicolo-ribaudo
Q | A |
---|---|
Fixed Issues? | Fixes #13366 |
Patch: Bug Fix? | 👍 |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | 👍 |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46894/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a0d7ec:
|
.../babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/exec.js
Outdated
Show resolved
Hide resolved
.../babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/exec.js
Outdated
Show resolved
Hide resolved
...l-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/options.json
Outdated
Show resolved
Hide resolved
.../babel-plugin-proposal-private-methods/test/fixtures/private-method/tagged-template/input.js
Outdated
Show resolved
Hide resolved
.../babel-plugin-proposal-private-methods/test/fixtures/static-accessors/tagged-template/exe.js
Outdated
Show resolved
Hide resolved
@nicolo-ribaudo Thanks for the comments. General question, Can i create a new commit (fixing review) and push to this PR or do i must keep it with a single commit (using commit --amend with force push)? |
packages/babel-helper-member-expression-to-functions/src/index.ts
Outdated
Show resolved
Hide resolved
.../babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/exec.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/exec.js
Outdated
Show resolved
Hide resolved
It's fine to add as many commits as needed to this PR. |
...babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/input.js
Outdated
Show resolved
Hide resolved
@nicolo-ribaudo @jridgewell I pushed the new changes per your comments |
@nicolo-ribaudo / @jridgewell Are we done here? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few more comments about tests; apart from them it looks good 👍
.../babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/exec.js
Show resolved
Hide resolved
packages/babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template/input.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/exec.js
Show resolved
Hide resolved
...abel-plugin-proposal-private-methods/test/fixtures/static-accessors/tagged-template/input.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template/exec.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template/exec.js
Outdated
Show resolved
Hide resolved
...babel-plugin-proposal-class-properties/test/fixtures/private/tagged-template-static/input.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/exec.js
Show resolved
Hide resolved
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/input.js
Show resolved
Hide resolved
...s/babel-plugin-proposal-private-methods/test/fixtures/private-method/tagged-template/exec.js
Outdated
Show resolved
Hide resolved
...plugin-proposal-private-methods/test/fixtures/private-static-method/tagged-template/input.js
Outdated
Show resolved
Hide resolved
...abel-plugin-proposal-private-methods/test/fixtures/static-accessors/tagged-template/input.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just a few more comments (that I screwed up). If you can make these changes, run update the tests one last time, this should be good to merge.
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/exec.js
Outdated
Show resolved
Hide resolved
packages/babel-plugin-proposal-private-methods/test/fixtures/accessors/tagged-template/input.js
Show resolved
Hide resolved
...abel-plugin-proposal-private-methods/test/fixtures/static-accessors/tagged-template/input.js
Outdated
Show resolved
Hide resolved
@jridgewell Thanks, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍