-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator performance #13593
Generator performance #13593
Conversation
baseline 256 empty statements: 3_718 ops/sec ±18.65% (0.269ms) baseline 512 empty statements: 2_070 ops/sec ±0.96% (0.483ms) baseline 1024 empty statements: 1_012 ops/sec ±1.76% (0.988ms) baseline 2048 empty statements: 510 ops/sec ±1.53% (1.96ms) current 256 empty statements: 3_965 ops/sec ±21.14% (0.252ms) current 512 empty statements: 2_219 ops/sec ±1.29% (0.451ms) current 1024 empty statements: 1_089 ops/sec ±1.53% (0.918ms) current 2048 empty statements: 548 ops/sec ±1.87% (1.824ms)
baseline 256 1-length identifiers: 1_947 ops/sec ±25.11% (0.514ms) baseline 512 1-length identifiers: 1_115 ops/sec ±0.89% (0.897ms) baseline 1024 1-length identifiers: 537 ops/sec ±1.71% (1.862ms) baseline 2048 1-length identifiers: 273 ops/sec ±0.57% (3.669ms) current 256 1-length identifiers: 2_178 ops/sec ±27.17% (0.459ms) current 512 1-length identifiers: 1_250 ops/sec ±1.19% (0.8ms) current 1024 1-length identifiers: 622 ops/sec ±0.71% (1.608ms) current 2048 1-length identifiers: 308 ops/sec ±1.35% (3.251ms)
baseline 256 25-length identifiers: 1_869 ops/sec ±29.4% (0.535ms) baseline 512 25-length identifiers: 1_092 ops/sec ±1.62% (0.916ms) baseline 1024 25-length identifiers: 537 ops/sec ±1.29% (1.862ms) baseline 2048 25-length identifiers: 264 ops/sec ±2% (3.793ms) current 256 25-length identifiers: 2_462 ops/sec ±23.38% (0.406ms) current 512 25-length identifiers: 1_401 ops/sec ±0.73% (0.714ms) current 1024 25-length identifiers: 671 ops/sec ±1.55% (1.491ms) current 2048 25-length identifiers: 332 ops/sec ±1.44% (3.014ms)
baseline 256 1-length identifiers: 2_678 ops/sec ±24.96% (0.373ms) baseline 512 1-length identifiers: 1_472 ops/sec ±2.33% (0.68ms) baseline 1024 1-length identifiers: 737 ops/sec ±1.74% (1.357ms) baseline 2048 1-length identifiers: 371 ops/sec ±0.79% (2.695ms) current 256 1-length identifiers: 2_633 ops/sec ±32.44% (0.38ms) current 512 1-length identifiers: 1_676 ops/sec ±1.49% (0.597ms) current 1024 1-length identifiers: 803 ops/sec ±1.95% (1.246ms) current 2048 1-length identifiers: 385 ops/sec ±2.22% (2.596ms)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9321162:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47494/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access the "isQueries" in
@babel/types
is extremely slow. In this PR we hoist them to top level. Unfortunately we can not use the import namespace specifiers such asimport { isIdentifier } from "@babel/types"
because Babel replaces them totypes.isIdentifier
.
We might use a custom plugin to replace import { isIdentifier } from "@babel/types"
to import * as _t from "@babel/types"; const { isIdentifier } = _t
in every package.
isVariableDeclarator, | ||
isWhileStatement, | ||
isYieldExpression, | ||
} = t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It would probably make sense to run this as a babel transformer automatically? That would let us take care of charCodes.foo
, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transform-charcodes
plugin replaces things like charCodes.lineFeed
with 10
so it's even better!
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* bench: setup benchmarks * add charcodes * perf: use string as buffer backend baseline 256 empty statements: 3_718 ops/sec ±18.65% (0.269ms) baseline 512 empty statements: 2_070 ops/sec ±0.96% (0.483ms) baseline 1024 empty statements: 1_012 ops/sec ±1.76% (0.988ms) baseline 2048 empty statements: 510 ops/sec ±1.53% (1.96ms) current 256 empty statements: 3_965 ops/sec ±21.14% (0.252ms) current 512 empty statements: 2_219 ops/sec ±1.29% (0.451ms) current 1024 empty statements: 1_089 ops/sec ±1.53% (0.918ms) current 2048 empty statements: 548 ops/sec ±1.87% (1.824ms) * perf: add endsWithCharAndNewline baseline 256 1-length identifiers: 1_947 ops/sec ±25.11% (0.514ms) baseline 512 1-length identifiers: 1_115 ops/sec ±0.89% (0.897ms) baseline 1024 1-length identifiers: 537 ops/sec ±1.71% (1.862ms) baseline 2048 1-length identifiers: 273 ops/sec ±0.57% (3.669ms) current 256 1-length identifiers: 2_178 ops/sec ±27.17% (0.459ms) current 512 1-length identifiers: 1_250 ops/sec ±1.19% (0.8ms) current 1024 1-length identifiers: 622 ops/sec ±0.71% (1.608ms) current 2048 1-length identifiers: 308 ops/sec ±1.35% (3.251ms) * perf: avoid one byte string compare * perf: avoid scaning word for / * perf: hoist babel type methods baseline 256 25-length identifiers: 1_869 ops/sec ±29.4% (0.535ms) baseline 512 25-length identifiers: 1_092 ops/sec ±1.62% (0.916ms) baseline 1024 25-length identifiers: 537 ops/sec ±1.29% (1.862ms) baseline 2048 25-length identifiers: 264 ops/sec ±2% (3.793ms) current 256 25-length identifiers: 2_462 ops/sec ±23.38% (0.406ms) current 512 25-length identifiers: 1_401 ops/sec ±0.73% (0.714ms) current 1024 25-length identifiers: 671 ops/sec ±1.55% (1.491ms) current 2048 25-length identifiers: 332 ops/sec ±1.44% (3.014ms) * perf: hoist parens methods baseline 256 1-length identifiers: 2_678 ops/sec ±24.96% (0.373ms) baseline 512 1-length identifiers: 1_472 ops/sec ±2.33% (0.68ms) baseline 1024 1-length identifiers: 737 ops/sec ±1.74% (1.357ms) baseline 2048 1-length identifiers: 371 ops/sec ±0.79% (2.695ms) current 256 1-length identifiers: 2_633 ops/sec ±32.44% (0.38ms) current 512 1-length identifiers: 1_676 ops/sec ±1.49% (0.597ms) current 1024 1-length identifiers: 803 ops/sec ±1.95% (1.246ms) current 2048 1-length identifiers: 385 ops/sec ±2.22% (2.596ms) * cleanup unused benchcase * Update packages/babel-generator/src/buffer.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * cleanup benchmarks Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
This PR improves the
@babel/generator
performance.Buffer#_endsWith
are rewritten to avoid scanning the_queue
string[i] === "another one byte string"
is replaced bystring.charCodeAt(i) === charCodes
@babel/types
is extremely slow. In this PR we hoist them to top level. Unfortunately we can not use the import namespace specifiers such asimport { isIdentifier } from "@babel/types"
because Babel replaces them totypes.isIdentifier
.See commit messages for commit-by-commit performance reports.
In a real world case
jquery-3.6.txt
, we see 50% performance improvements compared to@babel/generator
7.14.5Many empty statements
Many 1-length identifiers
Many 25-length identifiers