-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @types/node
for vm
module
#13738
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 946c0fa:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48587/ |
let cached: { code?: string; cachedData?: Buffer } = | ||
cachedScripts.get(filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of here, can you move the type annotation to the cachedScripts
definition? Something like new QuickLRU<string, { code: string; cachedData?: Buffer }>()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 10a57fe
Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Before
After
Fix type at DefinitelyTyped/DefinitelyTyped#55418 and install @types/node v16.7.13