await using normative updates
#16537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Spec Compliance 👓
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57425 |
JLHwung
force-pushed
the
await-using-normative-updates
branch
from
e60eacb
to
2aa75eb
Compare
Comment on lines
+36
to
+76
| if (isAwait) { | ||
| var inner = dispose; | ||
| } |
There was a problem hiding this comment.
var inner = isAwait && dispose;
Will this be smaller?
There was a problem hiding this comment.
- // size: 972, gzip size: 498
+ // size: 971, gzip size: 500It will save one byte for plaintext but the compressed size is increased by 2.
liuxingbaoyu
approved these changes
May 31, 2024
|
Could you include tc39/proposal-explicit-resource-management#219 too? |
JLHwung
force-pushed
the
await-using-normative-updates
branch
2 times, most recently
from
898b27d
to
631f722
Compare
|
It seems that the CI failure on Node.js 8 is due to a platform-specific bug. I will skip the new test for Node < 10. |
nicolo-ribaudo
approved these changes
Jul 3, 2024
JLHwung
commented
Jul 3, 2024
| if (resource.a) { | ||
| return Promise.resolve(disposalResult).then(next, err); | ||
| if (!resource.a && state === StateFlag.NEEDS_AWAIT) { | ||
| state = StateFlag.NONE; |
There was a problem hiding this comment.
Note: If tc39/proposal-explicit-resource-management#219 (comment) gets consensus, we can simply change this line to state = StateFlag.HAS_AWAITED. Before that happens we implement the 2024-06 version as-is.
JLHwung
force-pushed
the
await-using-normative-updates
branch
from
7a63e72
to
b9602b1
Compare
This was referenced Aug 16, 2024
This was referenced Sep 5, 2024
This was referenced Sep 5, 2024
This was referenced Sep 6, 2024
Open
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following normative changes:
Symbol.disposemethod in an await using declaration is ignoredSymbol.disposemethod in an await using declaration are turned into promise rejections.Both of them are supported via a wrapper around the
Symbol.disposemethod.This PR also fixes a compliance issue: When searching a dispose method, Babel will not fallback to
Symbol.disposeifSymbol.asyncDisposemethod isnullordocument.all.