add some more flow types

[hzoo]

Also revert #3275

[amasad]

failing

[hzoo]

This is only passing on node 5

packages/babel-code-frame/src/index.js:6
  6: import esutils from "esutils";
                         ^^^^^^^^^ esutils. Required module not found

so i'm assuming this is an issue with npm 2?

[codecov-io]

Current coverage is 85.05%

Merging #3186 into master will decrease coverage by -0.24% as of f3ceb1b

@@            master   #3186   diff @@
======================================
  Files          215     215       
  Stmts        15773   15773       
  Branches      3382    3382       
  Methods          0       0       
======================================
- Hit          13454   13416    -38
- Partial        688     725    +37
- Missed        1631    1632     +1

Review entire Coverage Diff as of f3ceb1b

Powered by Codecov. Updated on successful CI builds.

[amasad]

let me know when this is ready 💅

[hzoo]

I suppose it is (since it finally passes)? I dono what is going on with ^ esutils. Required module not found - it sounds like it has to do with how flow does require statements and something with npm 2 since it works in node 5 / npm 3. I had to remove flowcheck from those 2 files

[amasad]

Is it hard to update the CI to node 5 / npm 3?

[hzoo]

What do you mean? https://github.com/babel/babel/blob/master/.travis.yml our travis has 0.10, etc which are all npm 2. Do you mean doing something like npm install npm@3 -g for the older versions?

[amasad]

That or maybe just run flow on node 5 environments:

node_v=`node -v`
if [ "$node_v" = "v5.5.0" ]; then flow; fi

or something like that

[hzoo]

Ooh something like that sounds good actually. Can just check node > 5

[amasad]

Yeah needs a bit more bash fu than I have to parse the int but it's doable.

[hzoo]

time to google (or I just write it in js and call the script).

[amasad]

Lol why not

[hzoo]

Ok probably lazy/unnecessary but it works.

[amasad]

Cool, do you want to revert the noflow checks you had to add?

[hzoo]

Yeah I did already 😎

[hzoo]

Although I think I can remove some more