Remove await* from babel-generator, add parsing error to babylon - (fixes T6688) #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
force-pushed
the
remove-await-star
branch
from
bd1f772
to
70f9faf
Compare
hzoo
force-pushed
the
remove-await-star
branch
from
70f9faf
to
276c98f
Compare
| @@ -968,7 +968,10 @@ pp.parseAwait = function (node) { | |||
| if (this.isLineTerminator()) { | |||
| this.unexpected(); | |||
| } | |||
| node.all = this.eat(tt.star); | |||
| node.all = false; | |||
There was a problem hiding this comment.
Can remove this and then fixup the tests (since otherwise it's node.all being undefined)
There was a problem hiding this comment.
yeah, I don't see any use for it.
Current coverage is
|
|
LGTM, just remove the node.all |
|
Ok removed and fixed tests |
amasad
added a commit
that referenced
this pull request
Dec 23, 2015
Remove await* from babel-generator, add parsing error to babylon - (fixes T6688)
JacopKane
pushed a commit
to JacopKane/babel
that referenced
this pull request
Jan 11, 2018
Remove await* from babel-generator, add parsing error to babylon - (fixes T6688)
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.babeljs.io/T6688
I think this works?
Ok need to fix up some tests