Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArrayExpression.elements.default #3261

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

jmm
Copy link
Member

@jmm jmm commented Jan 12, 2016

I'd like to add a test for this, but #3174 isn't merged yet :(

@codecov-io
Copy link

Current coverage is 85.02%

Merging #3261 into master will decrease coverage by -0.24% as of 0f85e79

@@            master   #3261   diff @@
======================================
  Files          215     215       
  Stmts        15706   15706       
  Branches      3360    3360       
  Methods          0       0       
======================================
- Hit          13391   13354    -37
- Partial        673     709    +36
- Missed        1642    1643     +1

Review entire Coverage Diff as of 0f85e79

Powered by Codecov. Updated on successful CI builds.

@amasad
Copy link
Member

amasad commented Jan 12, 2016

why is the test dependent on #3174?

@jmm
Copy link
Member Author

jmm commented Jan 12, 2016

@amasad babel-types has no test infrastructure currently. I suppose I could test it indirectly via some other package, but to me it seems better to get tests up and running for babel-types.

@amasad
Copy link
Member

amasad commented Jan 13, 2016

ah, cool. In what cases does ArrayExpression need a default?

@hzoo
Copy link
Member

hzoo commented Jan 13, 2016

I suppose if you want to do t.arrayExpression() instead of t.arrayExpression([])

@jmm
Copy link
Member Author

jmm commented Jan 13, 2016

@amasad Yes, just what @hzoo said: when you have reason to insert an empty array literal into the AST.

amasad added a commit that referenced this pull request Jan 14, 2016
Add ArrayExpression.elements.default
@amasad amasad merged commit d3242e8 into babel:master Jan 14, 2016
@jmm jmm deleted the array-expr-builder-default branch January 19, 2016 22:18
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants