New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6726 ignore config option #3644

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
10 participants
@subtleGradient
Contributor

subtleGradient commented Aug 8, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 8, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3644 into master will not change coverage

@@             master      #3644   diff @@
==========================================
  Files           188        188          
  Lines         10924      10924          
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
  Hits           9628       9628          
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update a2d66c0...87f7d04

codecov-io commented Aug 8, 2016

Current coverage is 88.13% (diff: 100%)

Merging #3644 into master will not change coverage

@@             master      #3644   diff @@
==========================================
  Files           188        188          
  Lines         10924      10924          
  Methods        1162       1162          
  Messages          0          0          
  Branches       2492       2492          
==========================================
  Hits           9628       9628          
  Misses         1296       1296          
  Partials          0          0          

Powered by Codecov. Last update a2d66c0...87f7d04

@STRML

This comment has been minimized.

Show comment
Hide comment
@STRML

STRML Aug 21, 2016

Contributor

This is a really annoying bug and contradicts the docs. Could someone please review and merge it ASAP?

Contributor

STRML commented Aug 21, 2016

This is a really annoying bug and contradicts the docs. Could someone please review and merge it ASAP?

@probablyup

This comment has been minimized.

Show comment
Hide comment
@probablyup

probablyup commented Aug 23, 2016

@hzoo ?

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Aug 23, 2016

Member

So sorry for the delay, I'm not particularly familiar with this of the codebase but @kittens says it was probably an artifact of some older code at the time. 67201e9

I think it's leftover from when babel.transform didn't actually return if a file was ignroed
so if we left it up to babel.transform then we'd just return the code verbatim and wouldn't do anything to it and we'd write it to the file system

Member

hzoo commented Aug 23, 2016

So sorry for the delay, I'm not particularly familiar with this of the codebase but @kittens says it was probably an artifact of some older code at the time. 67201e9

I think it's leftover from when babel.transform didn't actually return if a file was ignroed
so if we left it up to babel.transform then we'd just return the code verbatim and wouldn't do anything to it and we'd write it to the file system

@hzoo hzoo merged commit 2a4186f into babel:master Aug 23, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a2d66c0...87f7d04
Details
codecov/project 88.13% (+0.00%) compared to a2d66c0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gcedo

This comment has been minimized.

Show comment
Hide comment
@gcedo

gcedo Sep 26, 2016

I am continuing to experience this bug, babel-cli@6.14.0. Now the ignore option is supported, but files are not ignored recursively.

E.g., declaring:

"ignore": [
        "node_modules"
]

Will cause the build to fail anyway because, as babel will try to transpile files deep down in the node_modules hierarchy:

69% 1206/1215 build modulesnode_modules/babel-plugin-react-transform/lib/index.js -> dist/node_modules/babel-plugin-react-transform/lib/index.js

gcedo commented Sep 26, 2016

I am continuing to experience this bug, babel-cli@6.14.0. Now the ignore option is supported, but files are not ignored recursively.

E.g., declaring:

"ignore": [
        "node_modules"
]

Will cause the build to fail anyway because, as babel will try to transpile files deep down in the node_modules hierarchy:

69% 1206/1215 build modulesnode_modules/babel-plugin-react-transform/lib/index.js -> dist/node_modules/babel-plugin-react-transform/lib/index.js
@danez

This comment has been minimized.

Show comment
Hide comment
@danez

danez Sep 26, 2016

Member

@gcedo Does it work if you specify the option on the command line?

babel --ignore 'node_modules' ... 
Member

danez commented Sep 26, 2016

@gcedo Does it work if you specify the option on the command line?

babel --ignore 'node_modules' ... 
@gcedo

This comment has been minimized.

Show comment
Hide comment
@gcedo

gcedo Sep 26, 2016

Yes, it does. As I have seen the bug fix I have moved the options in .babelrc, but now it fails 😢

gcedo commented Sep 26, 2016

Yes, it does. As I have seen the bug fix I have moved the options in .babelrc, but now it fails 😢

@danez

This comment has been minimized.

Show comment
Hide comment
@danez

danez Sep 26, 2016

Member

Can you please open a new issue, so we do not forget about it. Thanks

Member

danez commented Sep 26, 2016

Can you please open a new issue, so we do not forget about it. Thanks

@pdillon

This comment has been minimized.

Show comment
Hide comment
@pdillon

pdillon Oct 11, 2016

@danez Opened #4707 and corresponding PR #4708

pdillon commented Oct 11, 2016

@danez Opened #4707 and corresponding PR #4708

@cula

This comment has been minimized.

Show comment
Hide comment
@cula

cula Apr 25, 2017

Happen again on babel 6.24.0

cula commented Apr 25, 2017

Happen again on babel 6.24.0

@sabeurthabti

This comment has been minimized.

Show comment
Hide comment
@sabeurthabti

sabeurthabti Jan 27, 2018

happens on 6.26.0

sabeurthabti commented Jan 27, 2018

happens on 6.26.0

MartijnHols added a commit to WoWAnalyzer/WoWAnalyzer that referenced this pull request Mar 11, 2018

@lock lock bot added the outdated label May 2, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.