Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'only' and 'ignore' options from config as defaults for babel-cli #4708

Closed
wants to merge 2 commits into from

Conversation

pdillon
Copy link

@pdillon pdillon commented Oct 11, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets #4707
License MIT

Fixes #4707. Could be expanded to other default options to be overridden by cli options.

@codecov-io
Copy link

codecov-io commented Oct 11, 2016

Current coverage is 88.83% (diff: 100%)

Merging #4708 into master will not change coverage

@@             master      #4708   diff @@
==========================================
  Files           195        195          
  Lines         13794      13794          
  Methods        1427       1427          
  Messages          0          0          
  Branches       3176       3176          
==========================================
  Hits          12254      12254          
  Misses         1540       1540          
  Partials          0          0          

Powered by Codecov. Last update 760bbd6...d63c866

@STRML
Copy link
Contributor

STRML commented Jan 5, 2017

Thanks for the fix @pdillon. Any reason why this is sitting so long? This deviation from the docs and intended behavior is quite surprising.

@pdillon
Copy link
Author

pdillon commented Jan 12, 2017

@STRML Sorry missed this last week. No idea why it's sitting. Expected to see some comment on it a while back.

@loganfsmyth
Copy link
Member

loganfsmyth commented Apr 10, 2017

As mentioned in #4707, this will be fixed in 7.x via #5487

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.babelrc "ignore", "only" options are ignored if another config is scanned in subfolder
4 participants