[7.0] Deprecate babel-core/register.js #5132
Conversation
chicoxyzzy
commented
Jan 15, 2017
chicoxyzzy
commented
| Q | A |
|---|---|
| Patch: Bug Fix? | no |
| Major: Breaking Change? | yes |
| Minor: New Feature? | no |
| Deprecations? | yes |
| Spec Compliancy? | no |
| Tests Added/Pass? | no |
| Fixed Tickets | |
| License | MIT |
| Doc PR | no |
| Dependency Changes | no |
Current coverage is 89.21% (diff: 100%)@@ 7.0 #5132 diff @@
==========================================
Files 203 203
Lines 9828 9828
Methods 1071 1071
Messages 0 0
Branches 2616 2616
==========================================
Hits 8768 8768
Misses 1060 1060
Partials 0 0
|
hzoo
added
the
PR: Breaking Change 💥
| @@ -1,3 +0,0 @@ | |||
| /* eslint max-len: 0 */ | |||
| // TODO: eventually deprecate this console.trace("use the `babel-register` package instead of `babel-core/register`"); | |||
| module.exports = require("babel-register"); | |||
There was a problem hiding this comment.
I think there a lot of user relying on this.
Could we emit the warning for a period of time? Could remove this in a minor release later on.
There was a problem hiding this comment.
Removing this is a breaking change regardless of the warning presence so it should be removed in one of majors.
There was a problem hiding this comment.
This was deprecated for a long time, so I think we should remove it. Not sure if we should do a warning.
There was a problem hiding this comment.
I guess the place that would be the hardest to migrate from this would be build systems; or you get into a situation where you need a build system to build a build system so you can build (your build system)...
Nvm, the above is true, but this change is unrelated
There was a problem hiding this comment.
Could we add an error as in packages/babel/index.js?
I don't want people to loose time about the resolution of this issue, what do you think?
There was a problem hiding this comment.
Good idea. I'll do it
chicoxyzzy
force-pushed
the
deprecate_babel-core_register
branch
from
ebfa143
to
6f28bfc
Compare
chicoxyzzy
force-pushed
the
deprecate_babel-core_register
branch
from
6f28bfc
to
dee5d53
Compare
lock
bot
added
the
outdated
