Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Deprecate babel-core/register.js #5132

Merged
merged 2 commits into from Jan 20, 2017

Conversation

@chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Jan 15, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? yes
Minor: New Feature? no
Deprecations? yes
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets
License MIT
Doc PR no
Dependency Changes no
@danez danez added this to the Babel 7 milestone Jan 15, 2017
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 15, 2017

Current coverage is 89.21% (diff: 100%)

Merging #5132 into 7.0 will not change coverage

@@                7.0      #5132   diff @@
==========================================
  Files           203        203          
  Lines          9828       9828          
  Methods        1071       1071          
  Messages          0          0          
  Branches       2616       2616          
==========================================
  Hits           8768       8768          
  Misses         1060       1060          
  Partials          0          0          

Powered by Codecov. Last update 56ac8b8...6f28bfc

@@ -1,3 +0,0 @@
/* eslint max-len: 0 */
// TODO: eventually deprecate this console.trace("use the `babel-register` package instead of `babel-core/register`");
module.exports = require("babel-register");

This comment has been minimized.

@xtuc

xtuc Jan 16, 2017
Member

I think there a lot of user relying on this.

Could we emit the warning for a period of time? Could remove this in a minor release later on.

(first link for "babel mocha" on Google)

This comment has been minimized.

@chicoxyzzy

chicoxyzzy Jan 16, 2017
Author Member

Removing this is a breaking change regardless of the warning presence so it should be removed in one of majors.

This comment has been minimized.

@danez

danez Jan 16, 2017
Member

This was deprecated for a long time, so I think we should remove it. Not sure if we should do a warning.

This comment has been minimized.

@Jessidhia

Jessidhia Jan 19, 2017
Member

I guess the place that would be the hardest to migrate from this would be build systems; or you get into a situation where you need a build system to build a build system so you can build (your build system)...

Nvm, the above is true, but this change is unrelated

This comment has been minimized.

@xtuc

xtuc Jan 19, 2017
Member

Could we add an error as in packages/babel/index.js?

I don't want people to loose time about the resolution of this issue, what do you think?

This comment has been minimized.

@chicoxyzzy

chicoxyzzy Jan 19, 2017
Author Member

Good idea. I'll do it

@chicoxyzzy chicoxyzzy force-pushed the chicoxyzzy:deprecate_babel-core_register branch from ebfa143 to 6f28bfc Jan 19, 2017
@chicoxyzzy chicoxyzzy force-pushed the chicoxyzzy:deprecate_babel-core_register branch from 6f28bfc to dee5d53 Jan 19, 2017
@hzoo hzoo merged commit 3a5ce62 into babel:7.0 Jan 20, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chicoxyzzy chicoxyzzy deleted the chicoxyzzy:deprecate_babel-core_register branch Jan 20, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.