Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes + Move babel-core config processing from transformation/file/options into top-level folder #5489

Merged
merged 16 commits into from
Mar 21, 2017
Merged

Misc fixes + Move babel-core config processing from transformation/file/options into top-level folder #5489

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
62def8d
Make presets consistently resolve string values relative to their con…
loganfsmyth Mar 15, 2017
344f0a6
Centralize preset processing from two loops to one.
loganfsmyth Mar 15, 2017
bf13ed4
Limit where certain arguments are allowed in Babel config.
loganfsmyth Mar 15, 2017
38720ae
Remove store subclassing from Plugin class.
loganfsmyth Mar 16, 2017
05ee30c
Use the standard option parser to load the internal plugins.
loganfsmyth Mar 16, 2017
6c4810c
Move Plugin class to be part of config loading, independent of File.
loganfsmyth Mar 16, 2017
12a2124
Move the deeply nested option logic to a toplevel folder.
loganfsmyth Mar 16, 2017
3e2d731
Move the Store class to be inside transformation.
loganfsmyth Mar 16, 2017
b71569f
Remove unneeded util.js file.
loganfsmyth Mar 16, 2017
7b5d4fe
Resolve parser and generator plugins in configuration resolution.
loganfsmyth Mar 16, 2017
f3f907b
Remove unneeded helper file.
loganfsmyth Mar 16, 2017
3c63431
Move config loading helpers into config folder.
loganfsmyth Mar 16, 2017
a15de19
Encapsulate config loading in config/ index file.
loganfsmyth Mar 16, 2017
534f621
remove unused use of removed util class
hzoo Mar 17, 2017
4901f33
remove unnecessary call
hzoo Mar 21, 2017
7551a8e
Update yarn.lock
hzoo Mar 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/babel-core/src/transformation/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import OptionManager from "./file/options/option-manager";
import * as messages from "babel-messages";
import Store from "../store";
import traverse from "babel-traverse";
import clone from "lodash/clone";

const GLOBAL_VISITOR_PROPS = ["enter", "exit"];

export default class Plugin extends Store {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I guess we never had to use .get/.set?

Actually what about https://github.com/babel/babel/blob/7.0/packages/babel-plugin-transform-runtime/src/index.js#L32

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this in that example is an instance of PluginPass, not Plugin. The only place Plugin was ever even exposed was this.plugin which I'm removing in this PR too, so removing the subclassing won't hurt anything that isn't already broken by that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I couldn't tell so I just assumed it was Plugin (and of course the tests passes so it's good, just was confused)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah understanding where each type of class is used is super confusing.

export default class Plugin {
constructor(plugin: Object, key?: string) {
super();

this.initialized = false;
this.raw = Object.assign({}, plugin);
this.key = this.take("name") || key;
Expand Down