Account for template literals revision #5523

hzoo · 2017-03-22T15:21:36Z

Input

tag`\unicode and \u{55}`;

Output

function _taggedTemplateLiteral(strings, raw) { return Object.freeze(Object.defineProperties(strings, { raw: { value: Object.freeze(raw) } })); }
var _templateObject = _taggedTemplateLiteral([], ["\\unicode and \\u{55}"]);
tag(_templateObject);

Fixes #4798

need to add more tests
also release a version of babylon that removes the need for the plugin since it's stage 4

cc @bakkot @TimothyGu

codecov · 2017-03-22T15:46:00Z

Codecov Report

Merging #5523 into 7.0 will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              7.0    #5523      +/-   ##
==========================================
+ Coverage   85.38%   85.39%   +<.01%     
==========================================
  Files         200      200              
  Lines        9492     9495       +3     
  Branches     2696     2698       +2     
==========================================
+ Hits         8105     8108       +3     
  Misses        889      889              
  Partials      498      498

Impacted Files	Coverage Δ
...in-transform-es2015-template-literals/src/index.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492ee95...b7aa909. Read the comment docs.

Jessidhia · 2017-03-22T15:55:00Z

...plugin-transform-es2015-template-literals/test/fixtures/normal/template-revision/expected.js

+    _templateObject6 = _taggedTemplateLiteral(["left", "right"], ["left", "\\u000g", "right"]),
+    _templateObject7 = _taggedTemplateLiteral(["left", "right"], ["left", "\\u{-0}", "right"]);
+
+function _taggedTemplateLiteral(strings, raw) { return Object.freeze(Object.defineProperties(strings, { raw: { value: Object.freeze(raw) } })); }


I actually didn't know this required defineProperty :o

i didn't either - maybe this..
right this is the non-loose mode one.

function _taggedTemplateLiteralLoose(strings, raw) { strings.raw = raw; return strings; }

loganfsmyth · 2017-03-22T19:00:10Z

packages/babel-plugin-transform-es2015-template-literals/src/index.js

@@ -18,7 +18,9 @@ export default function ({ types: t }) {
        let raw = [];

        for (const elem of (quasi.quasis: Array)) {
-          strings.push(t.stringLiteral(elem.value.cooked));
+          if (elem.value.cooked !== null) {


Should this be left out, or explicitly be undefined/void 0 in the array?

Not sure what's supposed to happen for .length of strs or if there is danger that one of several pieces might be missing cooked, like what is the output for \unicode${45}\u0065, are both pieces missing the .cooked?

It should be present with value undefined. Length is still the same as that of .raw.

Cool. Is every cooked value excluded if one is, or is it each individual value either may or may not use invalid escapes independent of the others?

They're independent. (That's how Babylon constructs the AST, too.)

Cool, wanted to verify my understanding then. So @hzoo this should do

const value = elem.value.cooked == null ? t.unaryExpression("void", t.numericLiteral(0)) : t.stringLiteral(elem.value.cooked); strings.push(value);

what about just t.identifier("undefined")? turns into void 0 already I thought

-var _templateObject = _taggedTemplateLiteral([undefined], ["\\unicode and \\u{55}"]), - _templateObject2 = _taggedTemplateLiteral([undefined], ["\\01"]), - _templateObject3 = _taggedTemplateLiteral([undefined, "right"], ["\\xg", "right"]), - _templateObject4 = _taggedTemplateLiteral(["left", undefined], ["left", "\\xg"]), - _templateObject5 = _taggedTemplateLiteral(["left", undefined, "right"], ["left", "\\xg", "right"]), - _templateObject6 = _taggedTemplateLiteral(["left", undefined, "right"], ["left", "\\u000g", "right"]), - _templateObject7 = _taggedTemplateLiteral(["left", undefined, "right"], ["left", "\\u{-0}", "right"]); +var _templateObject = _taggedTemplateLiteral([], ["\\unicode and \\u{55}"]), + _templateObject2 = _taggedTemplateLiteral([], ["\\01"]), + _templateObject3 = _taggedTemplateLiteral(["right"], ["\\xg", "right"]), + _templateObject4 = _taggedTemplateLiteral(["left"], ["left", "\\xg"]), + _templateObject5 = _taggedTemplateLiteral(["left", "right"], ["left", "\\xg", "right"]), + _templateObject6 = _taggedTemplateLiteral(["left", "right"], ["left", "\\u000g", "right"]), + _templateObject7 = _taggedTemplateLiteral(["left", "right"], ["left", "\\u{-0}", "right"]);

k plz approve or thumb if ready 🙌

@hzoo var undefined = 0 works at least in sloppy mode, so you do need `void 0 or equivalent. Otherwise lgtm.

loganfsmyth · 2017-03-22T19:49:10Z

packages/babel-plugin-transform-es2015-template-literals/src/index.js

@@ -18,7 +18,10 @@ export default function ({ types: t }) {
        let raw = [];

        for (const elem of (quasi.quasis: Array)) {
-          strings.push(t.stringLiteral(elem.value.cooked));
+          const value = elem.value.cooked == null
+            ? t.identifier("undefined")


There could be a var undefined = 4 in the top scope of the module so it would break. You could also use path.scope.buildUndefinedNode()

yep sorry forgot the name of the method

hzoo · 2017-03-22T19:57:50Z

changed to use path.scope.buildUndefinedNode() (although hasBinding has issues)

also added tests for spec/loose mode (no differences really)

hzoo · 2017-03-22T21:16:35Z

btw @bakkot do you want to be a collaborator? (messaged you on slack)

ljharb · 2017-05-08T19:44:35Z

Any chance this could be backported to v6?

xtuc · 2017-05-09T07:12:51Z

Yes this is a bug fix but also a breaking changes for people relying on this (don't want to know why 😄), it also require Babylon to backport it.

I don't think we want to land this on 6.

ljharb · 2017-05-09T07:21:39Z

Relying on a tagged template literal throwing?

loganfsmyth · 2017-05-09T08:14:49Z

I think this+babylon seems backportable. Probably a good issue to file as a help-wanted?

xtuc · 2017-05-09T08:22:55Z

As discussed on Slack, i'm fine landing this in 6.

Account for template literals revision

95c8292

hzoo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Mar 22, 2017

hzoo added this to the Babel 7 milestone Mar 22, 2017

extra tests

f56a037

Jessidhia reviewed Mar 22, 2017

View reviewed changes

hzoo mentioned this pull request Mar 22, 2017

remove babylon plugin for template revision since it's stage-4 babel/babylon#426

Merged

update to babylon beta 7

6800d3b

existentialism approved these changes Mar 22, 2017

View reviewed changes

loganfsmyth reviewed Mar 22, 2017

View reviewed changes

pr feedback (keep arr length the same)

b7aa909

hzoo force-pushed the template-literals-revision branch from eeb3e8f to b7aa909 Compare March 22, 2017 19:56

hzoo merged commit b638c8b into 7.0 Mar 22, 2017

hzoo mentioned this pull request Mar 22, 2017

Add to Upgrade Guide for Babel 7 babel/website#1209

Closed

hzoo deleted the template-literals-revision branch March 22, 2017 23:54

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Account for template literals revision #5523

Account for template literals revision #5523

hzoo commented Mar 22, 2017 •

edited

Loading

codecov bot commented Mar 22, 2017 •

edited

Loading

Jessidhia Mar 22, 2017

hzoo Mar 22, 2017 •

edited

Loading

loganfsmyth Mar 22, 2017

loganfsmyth Mar 22, 2017

bakkot Mar 22, 2017

loganfsmyth Mar 22, 2017 •

edited

Loading

bakkot Mar 22, 2017

loganfsmyth Mar 22, 2017

hzoo Mar 22, 2017 •

edited

Loading

hzoo Mar 22, 2017

bakkot Mar 22, 2017

loganfsmyth Mar 22, 2017

hzoo Mar 22, 2017

hzoo commented Mar 22, 2017

hzoo commented Mar 22, 2017

ljharb commented May 8, 2017

xtuc commented May 9, 2017

ljharb commented May 9, 2017

loganfsmyth commented May 9, 2017

xtuc commented May 9, 2017 •

edited

Loading

Account for template literals revision #5523

Account for template literals revision #5523

Conversation

hzoo commented Mar 22, 2017 • edited Loading

Input

Output

codecov bot commented Mar 22, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

hzoo Mar 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loganfsmyth Mar 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzoo Mar 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzoo commented Mar 22, 2017

hzoo commented Mar 22, 2017

ljharb commented May 8, 2017

xtuc commented May 9, 2017

ljharb commented May 9, 2017

loganfsmyth commented May 9, 2017

xtuc commented May 9, 2017 • edited Loading

hzoo commented Mar 22, 2017 •

edited

Loading

codecov bot commented Mar 22, 2017 •

edited

Loading

hzoo Mar 22, 2017 •

edited

Loading

loganfsmyth Mar 22, 2017 •

edited

Loading

hzoo Mar 22, 2017 •

edited

Loading

xtuc commented May 9, 2017 •

edited

Loading