Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor OptionManager to be a short class with a bunch of pure helper functions. #5602
Last PR before I post the changes to OptionManager for caching. This PR is basically slowly moving things around and simplifying OptionManager, so it no longer has all kinds of hard to follow statics. It's a simple class 100 lines long, with a bunch of pure functions that it uses to slowly build up the config info.
Review-wise it might be easier to just look at the final option-manager.js file to say what you think?
@@ Coverage Diff @@ ## 7.0 #5602 +/- ## ========================================== + Coverage 84.45% 84.48% +0.03% ========================================== Files 285 285 Lines 9648 9644 -4 Branches 2711 2700 -11 ========================================== Hits 8148 8148 + Misses 998 996 -2 + Partials 502 500 -2