Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove merge helper and add more type declarations. #5649

Merged
merged 1 commit into from Apr 19, 2017

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Apr 19, 2017

Added more types and removed our mergeWith helper because it is no longer needed now that plugin ordering is explicitly handled in option-manager from https://github.com/babel/babel/pull/5602/files#diff-86d518831fa938a96b0f375e1c81d207R111

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Apr 19, 2017

@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @forivall and @DmitrySoshnikov to be potential reviewers.

@loganfsmyth loganfsmyth force-pushed the loganfsmyth:more-types branch from 185a9bd to e11f1e2 Apr 19, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #5649 into 7.0 will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5649      +/-   ##
==========================================
+ Coverage   84.32%   84.39%   +0.06%     
==========================================
  Files         285      284       -1     
  Lines        9761     9753       -8     
  Branches     2737     2734       -3     
==========================================
  Hits         8231     8231              
+ Misses       1014     1008       -6     
+ Partials      516      514       -2
Impacted Files Coverage Δ
packages/babel-core/src/config/option-manager.js 76.19% <ø> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.85%) ⬆️
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%) ⬆️
packages/babel-traverse/src/path/context.js 86.2% <0%> (+1.72%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6af8e64...e11f1e2. Read the comment docs.

@loganfsmyth loganfsmyth merged commit 0eae6a4 into babel:7.0 Apr 19, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.39% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:more-types branch Apr 19, 2017

declare module "lodash/merge" {
declare export default <T: Object>(T, Object) => T;
}

This comment has been minimized.

Copy link
@xtuc

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Apr 19, 2017

Author Member

Yeah, I thought about it, but it only has declarations for the root lodash module, so since we use the lodash/merge and such, it didn't work. If we switch over to the global module we definitely can use flow-typed eventually though.

This comment has been minimized.

Copy link
@xtuc
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 'master' of github.com:hulkish/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* '7.0' of https://github.com/babel/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.