Fix async-to-generator ForAwait transform #5931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @zenparsing and @loganfsmyth to be potential reviewers. |
jridgewell
added
6.x: backport
PR: Bug Fix 🐛
jridgewell
force-pushed
the
fix-async-to-generator-forawait
branch
4 times, most recently
from
5e79c2f
to
4506844
Compare
The old transform called an external `babel-traverse`, which doesn’t does something funky.
jridgewell
force-pushed
the
fix-async-to-generator-forawait
branch
from
4506844
to
ceeb455
Compare
|
@jridgewell Did this ever land for Babel 6.x? |
|
@Andarist Thanks, this is good to know. |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fun one. The issue wasn't actually
transform-es2015-destructuring, buttransform-async-to-generatorusingbabel-traversedirectly.I'll also submit this for 7.0.