Fix async-to-generator ForAwait transform #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
added
the
PR: Bug Fix 🐛
|
@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @zenparsing and @existentialism to be potential reviewers. |
jridgewell
force-pushed
the
fix-async-to-generator-forawait-7.0
branch
from
8d80c56
to
ab83ca2
Compare
hzoo
approved these changes
Jul 10, 2017
The old transform called an external `babel-traverse`, which doesn’t does something funky.
jridgewell
force-pushed
the
fix-async-to-generator-forawait-7.0
branch
from
ab83ca2
to
d333f52
Compare
|
Whoops, output changed between 6.0 and 7.0. Fixed now. |
existentialism
approved these changes
Jul 10, 2017
4 tasks
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a fun one. The issue wasn't actually
transform-es2015-destructuring, buttransform-async-to-generatorusingbabel-traversedirectly.6.0 backport is #5931.