2nd try: Add loose option for es2015-parameters transformation #5943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
Jul 12, 2017
| return; | ||
| } | ||
|
|
||
| state.iife = false; |
There was a problem hiding this comment.
Please don't muck with the global state object.
| }; | ||
| const params = path.get("params"); | ||
|
|
||
| if (state.opts.loose) { |
There was a problem hiding this comment.
This can be referenced without state using this.
if (this.opts.loose) {
//...
}
jridgewell
approved these changes
Jul 12, 2017
existentialism
added
the
PR: New Feature 🚀
existentialism
approved these changes
Jul 12, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebuild of my changes discussed and approved in #5778, because I messed up the history of the other too much. This new PR should be up to date with 7.0 and apply all changes from the old PR within a single commit.