New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd try: Add loose option for es2015-parameters transformation #5943

Merged
merged 2 commits into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@maurobringolf
Contributor

maurobringolf commented Jul 12, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? Yes/Yes
Fixed Tickets Fixes #5776
License MIT
Doc PR
Dependency Changes

This is a rebuild of my changes discussed and approved in #5778, because I messed up the history of the other too much. This new PR should be up to date with 7.0 and apply all changes from the old PR within a single commit.

return;
}
state.iife = false;

This comment has been minimized.

@jridgewell

jridgewell Jul 12, 2017

Member

Please don't muck with the global state object.

};
const params = path.get("params");
if (state.opts.loose) {

This comment has been minimized.

@jridgewell

jridgewell Jul 12, 2017

Member

This can be referenced without state using this.

if (this.opts.loose) {
  //...
}

@jridgewell jridgewell merged commit b83e0ec into babel:7.0 Jul 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 85.8% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment