Rewrite parameter transform and drop _blockHoist reliance #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Internal 🏠
|
@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @jridgewell and @vhf to be potential reviewers. |
|
I didn't looked at every line, but overall it looks good. The testcase changes all make sense. |
|
Thanks @loganfsmyth for this (huge change to get rid of those _ props and @existentialism for rebasing! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases and closes #5709. Also applies loose mode change from #5943.