Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chai to 4.x #6002

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Update chai to 4.x #6002

merged 2 commits into from
Jul 24, 2017

Conversation

danez
Copy link
Member

@danez danez commented Jul 24, 2017

Q A
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Deprecations? n
Spec Compliancy? n
Tests Added/Pass? n
Fixed Tickets
License MIT
Doc PR
Dependency Changes

I had to change how chai gets required.

// in test file
assert.throws(fn, /test/)

chai would check if the second param is instanceOf RegExp, but this would be false as chai was required outside the testContext, so it is referencing a different global RegExp.
By requiring chai inside the testContext fixed this problem.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 24, 2017
@danez danez requested a review from loganfsmyth July 24, 2017 10:09
@hzoo hzoo merged commit 19c4dd2 into babel:7.0 Jul 24, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants