Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn engines #6064

Merged
merged 2 commits into from Aug 8, 2017

Conversation

@hzoo
Copy link
Member

hzoo commented Aug 8, 2017

Fixes #6063

Changed to >=

yarn install v0.28.1
[1/5] 馃攳  Validating package.json...
error babel@: The engine "yarn" is incompatible with this module. Expected version "^0.27.5".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 8, 2017

@hzoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @existentialism, @danez and @chicoxyzzy to be potential reviewers.

@existentialism existentialism merged commit 009d7f0 into 7.0 Aug 8, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.1% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Aug 10, 2017

This seems to break installing through nightly builds of Yarn, I guess because the major version number is different:

yarn install v1.0.0-20170809.1751
[1/5] Validating package.json...
error babel@: The engine "yarn" is incompatible with this module. Expected version ">=0.27.5".
error Found incompatible module

Not sure if this is a bug or a feature 馃槢

@hzoo hzoo deleted the yarn-engines branch Aug 15, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.