default to spec mode for template literal transform #6098

noahlemen · 2017-08-13T02:07:39Z

Q	A
Fixed Issues
Patch: Bug Fix?
Major: Breaking Change?	👌 (change to transform option)
Minor: New Feature?
Tests Added/Pass?
Spec Compliancy?
License	MIT
Doc PR
Any Dependency Changes?

Similar to #6076, change transform-es2015-template-literals to default to spec mode, with loose optional

When this was being discussed in slack, there was also talk of this transform not throwing errors properly in some cases, but I didn't totally follow. If this could be further clarified, I'd be happy to try to implement that fix in this PR as well.

noahlemen · 2017-08-13T02:09:52Z

transform-es2015-arrow-functions and babel-preset-es2015 still default to non-spec mode -- should these be updated?

jridgewell · 2017-08-23T03:51:46Z

packages/babel-plugin-transform-es2015-template-literals/src/index.js

        if (!t.isStringLiteral(nodes[0]) && considerSecondNode) {
          nodes.unshift(t.stringLiteral(""));
        }
        let root = nodes[0];

-        if (state.opts.spec) {
+        if (!state.opts.loose) {


Flip the if statements, please.

…rg tests

babel-bot · 2017-08-23T14:34:42Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4695/

babel-bot · 2017-08-23T14:34:43Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4690/

noahlemen · 2017-08-23T14:48:53Z

packages/babel-plugin-transform-es2015-template-literals/src/index.js

-            root = buildConcatCallExressions(nodes);
-          }
-        } else {
+        if (state.opts.loose) {


@jridgewell let me know if i misunderstood what you meant by "flip" here!

That was it.

noahlemen · 2017-08-23T14:55:51Z

^^^ oh man these integrated REPL builds are sliiiiiiick

nicolo-ribaudo · 2017-08-23T16:06:52Z

packages/babel-plugin-transform-es2015-template-literals/src/index.js

          for (let i = 1; i < nodes.length; i++) {
            root = t.binaryExpression("+", root, nodes[i]);
          }
+        } else {
+          if (nodes.length > 1) {


Can you also merge else { if ( -> else if (?

👍 great idea!

existentialism · 2017-08-23T16:17:26Z

packages/babel-plugin-transform-es2015-template-literals/README.md

-`boolean`, defaults to `false`.
-
-This option combines all template literal expressions and quasis with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).
+When `false` or not set, combines all template literal expressions and quasis with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).


When false or not set, combines all template...

Maybe:

When false or not set, all template literal expressions and quasis are combined with String.prototype.concat.

existentialism · 2017-08-23T16:19:09Z

packages/babel-plugin-transform-es2015-template-literals/README.md


 **In**

 ```javascript
 `foo${bar}baz${quux}${1}`;
 ```

-**Out**
+**Out (without `{"loose": true}`)**


I think it might be better if we update the example above with the default behavior, and keep this In/Out for loose: true

noahlemen · 2017-08-23T18:27:33Z

packages/babel-plugin-transform-es2015-template-literals/README.md


-This option combines all template literal expressions and quasis with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).
+When `false` or not set, all template literal expressions and quasis are combined with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).


should "See babel/babel#5791" stay or be removed?

hzoo · 2017-08-28T18:57:32Z

...ges/babel-plugin-transform-es2015-template-literals/test/fixtures/normal/tag-loose/actual.js

@@ -1,3 +0,0 @@
-var foo = bar`wow\na${ 42 }b ${_.foobar()}`;


did we mean to delete this tests or are the covered already?

that should be covered here:

https://github.com/kedromelon/babel/blob/0781ee36777cf885b366d7c3b1f7c0b0315caca1/packages/babel-plugin-transform-es2015-template-literals/test/fixtures/loose/tag/actual.js#L1

er, maybe that isn't the same? i might have been mistaken. thought there was some test duplication, but it can be hard to wrap your head around that while working with so many rennamed files 🙃

i'll have a chance to inspect this a bit more later. will check and submit a PR re-adding these tests if they were mistakenly removed

submitted #6169

hzoo · 2017-09-20T18:32:29Z

For documentation, this causes an issue with webpack if you are using dynamic imports with template strings because we turn import(`${a}`) into .concat which webpack doesn't handle.

Issue: webpack/webpack#5674
PR: webpack/webpack#5679

We made it default so the workaround is to just you a normal string concat (don't use template literals) or use loose mode until webpack updates.

{
    presets: [
      require('babel-preset-env'),
    ],
    plugins: [
      [
        require('babel-plugin-transform-es2015-template-literals'), { loose: true },
      ],
    ],
  };

or if you are using loose mode for everything:

{
    presets: [
      [require('babel-preset-env'), { loose: true }],
    ],
  };

noahlemen force-pushed the spec-template-literals branch from 04e56c6 to 8ec7656 Compare August 13, 2017 02:11

jridgewell requested changes Aug 23, 2017

View reviewed changes

noahlemen added 2 commits August 23, 2017 10:19

spec/loose/default switch for template literal transform, update/re-o…

96a3a11

…rg tests

update readme

58391de

noahlemen force-pushed the spec-template-literals branch from 8ec7656 to 58391de Compare August 23, 2017 14:19

flip if statements

5abfe20

noahlemen commented Aug 23, 2017

View reviewed changes

jridgewell approved these changes Aug 23, 2017

View reviewed changes

nicolo-ribaudo reviewed Aug 23, 2017

View reviewed changes

consolidate else/if

d52b045

existentialism reviewed Aug 23, 2017

View reviewed changes

existentialism added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Aug 23, 2017

readme wording modification, updates to examples

0781ee3

noahlemen force-pushed the spec-template-literals branch from ecd04bc to 0781ee3 Compare August 23, 2017 18:25

noahlemen commented Aug 23, 2017

View reviewed changes

hzoo merged commit 4080589 into babel:7.0 Aug 28, 2017

hzoo reviewed Aug 28, 2017

View reviewed changes

noahlemen mentioned this pull request Aug 30, 2017

re-add template literals tests, add ones that were missing #6169

Merged

noahlemen deleted the spec-template-literals branch August 30, 2017 00:23

noahlemen mentioned this pull request Aug 30, 2017

update transform-es2015-arrow-functions to default to spec mode #6170

Closed

3 tasks

loganfsmyth mentioned this pull request Sep 13, 2017

Support static analysis of "".concat("") in require() calls webpack/webpack#5674

Closed

hzoo mentioned this pull request Sep 16, 2017

Babel 7 twbs/bootstrap#23966

Merged

2 tasks

jridgewell mentioned this pull request Feb 9, 2018

Primitive conversion and template literals #7359

Closed

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default to spec mode for template literal transform #6098

default to spec mode for template literal transform #6098

noahlemen commented Aug 13, 2017

noahlemen commented Aug 13, 2017

jridgewell Aug 23, 2017

babel-bot commented Aug 23, 2017 •

edited

Loading

babel-bot commented Aug 23, 2017

noahlemen Aug 23, 2017

jridgewell Aug 23, 2017

noahlemen commented Aug 23, 2017

nicolo-ribaudo Aug 23, 2017

noahlemen Aug 23, 2017

existentialism Aug 23, 2017 •

edited

Loading

existentialism Aug 23, 2017 •

edited

Loading

noahlemen Aug 23, 2017 •

edited

Loading

hzoo Aug 28, 2017

noahlemen Aug 28, 2017

noahlemen Aug 28, 2017 •

edited

Loading

noahlemen Aug 28, 2017 •

edited

Loading

noahlemen Aug 30, 2017

hzoo commented Sep 20, 2017 •

edited

Loading


		This option combines all template literal expressions and quasis with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).
		When `false` or not set, all template literal expressions and quasis are combined with `String.prototype.concat`. It will handle cases with `Symbol.toPrimitive` correctly and throw correctly if template literal expression is a `Symbol()`. See [babel/babel#5791](https://github.com/babel/babel/pull/5791).

default to spec mode for template literal transform #6098

default to spec mode for template literal transform #6098

Conversation

noahlemen commented Aug 13, 2017

noahlemen commented Aug 13, 2017

Choose a reason for hiding this comment

babel-bot commented Aug 23, 2017 • edited Loading

babel-bot commented Aug 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noahlemen commented Aug 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

existentialism Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

existentialism Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

noahlemen Aug 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noahlemen Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

noahlemen Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzoo commented Sep 20, 2017 • edited Loading

babel-bot commented Aug 23, 2017 •

edited

Loading

existentialism Aug 23, 2017 •

edited

Loading

existentialism Aug 23, 2017 •

edited

Loading

noahlemen Aug 23, 2017 •

edited

Loading

noahlemen Aug 28, 2017 •

edited

Loading

noahlemen Aug 28, 2017 •

edited

Loading

hzoo commented Sep 20, 2017 •

edited

Loading