re-add template literals tests, add ones that were missing #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4741/ |
jridgewell
approved these changes
Aug 30, 2017
existentialism
added
the
PR: Internal 🏠
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #6098 and discussion at #6098 (comment), re-add some test coverage that was mistakenly removed
also, i added tests that were not present in opposite modes, figuring that there should be parity between test cases for loose/default modes. i can back out those changes if they are not necessary. in particular, i'm not sure if
loose/order,loose/order2, andloose/symbolare needed -- there was no variation in them between default and loose modes.