Extracted babel-helper-annotate-as-pure #6267
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4999/ |
Andarist
force-pushed
the
annotate-as-pure
branch
from
a9a83ea
to
9fd5d36
Compare
| if (leadingComments === undefined) { | ||
| return false; | ||
| } | ||
| return leadingComments.some(comment => /[@#]__PURE__/.test(comment.value)); |
There was a problem hiding this comment.
I wonder if there's a good way to prevent false positives here (so it doesn't match, say, "#__PURE___")
There was a problem hiding this comment.
actually this test is taken from the UglifyJS' source code, it tests it exactly like this, foo #__PURE__ bar are also allowed
There was a problem hiding this comment.
I think it would be convenient to have an PureAnnotation node in the Babel AST because It would probably be simpler to detect and manage. I assume babel/minify will also take advantage of it during minification.
There was a problem hiding this comment.
@xtuc I dont think thats actually possible, because ast -> code -> ast are not inverse operations (in mathematics sense) regarding comments
i.e. if we annotate each CallExpression with a leading comment in fn()()() we'll end up with nice AST - 1 comment for each node, when we generate code, we'll end up with
/*foo*//*foo*//*foo*/fn()()()And ofc if we go back to AST again we'll end up with 3 comments on the outermost CallExpression
| if (leadingComments === undefined) { | ||
| return false; | ||
| } | ||
| return leadingComments.some(comment => /[@#]__PURE__/.test(comment.value)); |
There was a problem hiding this comment.
I think it would be convenient to have an PureAnnotation node in the Babel AST because It would probably be simpler to detect and manage. I assume babel/minify will also take advantage of it during minification.
existentialism
added
the
PR: New Feature 🚀
lock
bot
added
the
outdated
This code is extracted from the #6231 and generally already got reviewed. I've split the mentioned PR into 2 because this part is ready and independent, the other one though still needs some discussion and approval.