Remove babel-messages and inline the usages #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
option-manager.js... /babel-core/src/config/ build-external-helpers.js... /packages/babel-core/src/tools/ index.js... /packages/babel-generator/src
package.json "babel-messages" removed: - babel-core - babel-helper-replace-supers - babel-plugin-transform-es2015-classes - babel-traverse "messages" remove from: - babel-plugin-check-es2015-constants/src/index.js - babel-plugin-transform-es2015-for-of/src/index.js export "babel-messages" removed from: - babel-core/src/index.js import "babel-messages" removed from: - babel-generator/src/index.js - babel-helper-replace-supers/src/index.js - babel-traverse/src/index.js - babel-traverse/src/scope/index.js - babel-traverse/src/visitors.js package "babel-messages" removed completely. 💯️ All tests pass.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5113/ |
jridgewell
approved these changes
Sep 30, 2017
hzoo
added
the
PR: Internal 🏠
existentialism
approved these changes
Sep 30, 2017
|
This is great, I also checked out locally with hub with Awesome teamwork @rouzbeh84 and @JeromeFitz on this one! Got to remove an unused package and a ~ 100 lines of code! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel-messages(and its reference from other babel-*package.json)