Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: useBuiltins: true is changed to "entry" #6527

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Update README: useBuiltins: true is changed to "entry" #6527

merged 1 commit into from
Oct 23, 2017

Conversation

exarus
Copy link
Contributor

@exarus exarus commented Oct 21, 2017

babel-preset-env@next founds "useBuiltins": true is illegal. README is updated accordingly.

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR 👍
Any Dependency Changes?

I've checked @babel/preset-env@next and found that "useBuiltins": true is illegal. Considering that:

  1. "useBuiltins": true doesn't work in @next version
  2. "useBuiltins": true is not documented
  3. "useBuiltins": "entry" works in @latest version

I suggest changing "useBuiltins": true to "useBuiltins": "entry"

Also I suggest that README is future-oriented because it specifies @babel/preset-env npm package that is currently absent in npm.

Special thanks to @existentialism for explaining the "useBuiltins": true option.

@exarus exarus changed the title Update README: useBuiltins doesn't use true value Update README: useBuiltins: true value Oct 21, 2017
@exarus exarus changed the title Update README: useBuiltins: true value Update README: useBuiltins: true is replaced Oct 21, 2017
@exarus exarus changed the title Update README: useBuiltins: true is replaced Update README: useBuiltins: true is changed to "entry" Oct 21, 2017
babel-preset-env@next founds "useBuiltins": true is illegal. README is updated accordingly.
@existentialism existentialism added the PR: Docs 📝 A type of pull request used for our changelog categories label Oct 21, 2017
@existentialism
Copy link
Member

@exarus the README is future-oriented, we're moving to scoped packages, so @babel/preset-env is correct, it just hasn't been published yet.

@existentialism existentialism merged commit 70818c3 into babel:master Oct 23, 2017
@exarus exarus deleted the patch-1 branch October 23, 2017 22:10
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Docs 📝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants