Add a 'throwIfNamespace' option for JSX transform #6563
Conversation
| * If there is flag "throwIfNamespace" | ||
| * print XMLNamespace like string literal | ||
| */ | ||
| return t.stringLiteral(node.namespace.name + ":" + node.name.name); |
There was a problem hiding this comment.
I'm not really sure about this, should I make some helper for it? (I've discovered that there is getQualifiedJSXName, so maybe something in this way.)
There was a problem hiding this comment.
Can a namespace be nested? I don't think a helper is necessary, and you can use a template literal here as well
There was a problem hiding this comment.
Ok looks like they can't be nested (parse error)
There was a problem hiding this comment.
I don't think that namespace could be nested. Ok, I will go for template literal, I've wanted to stay in style with getQualifiedJSXName implementation. 😆
|
It passes in travis so it's fine, looks like a cache issue or you aren't rebased |
|
@hzoo You are right. I've rebased it. 👍 |
xtuc
added
the
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5508/ |
| ); | ||
| if (opts.throwIfNamespace) { | ||
| throw path.buildCodeFrameError( | ||
| "Namespace tags are not supported. ReactJSX is not XML.", |
There was a problem hiding this comment.
By the way, the error message sounds a bit strange to me. What does ReactJSX is not XML mean? What do you think if we drop this part?
There was a problem hiding this comment.
Something the react team would of said? They are just saying the React's version of JSX looks like XML (which supports namespace tags) but it's not
We can reword it if you think that makes sense. "React's JSX doesn't support namespace tags (although it looks similar to XML which does)"
There was a problem hiding this comment.
Yes, I would prefer something like that.
There was a problem hiding this comment.
I tried something like this, feel free to reword this. 👍
|
@xtuc Sorry! I've added documentation in the last commit. |
|
|
||
| `boolean`, defaults to `true`. | ||
|
|
||
| This option controls how to handle XML Namespaces. React's don't support it thus default behavior is to throw an error when XML namespace occurs, this behavior could be suppressed by setting it to false. |
There was a problem hiding this comment.
Slight grammar nit:
React's don't -> React's JSX doesn't
Or maybe even:
Toggles whether or not to throw an error if a XML namespaced tag name is used. For example:
<f:image />Though the JSX spec allows this, it is disabled by default since React's JSX does not currently have support for it.
There was a problem hiding this comment.
@existentialism Thanks for the grammar 😥 . At the end, I've used your version. Providing an example is a good idea.
| if (opts.throwIfNamespace) { | ||
| throw path.buildCodeFrameError( | ||
| "Namespace tags are not supported by default. React's JSX doesn't support namespace tags." + | ||
| "You can turn on the 'throwIfNamespace' flag to bypass this warning.", |
There was a problem hiding this comment.
Does the template literal not work here? looks like this is all one line, and you need a space tags.You
There was a problem hiding this comment.
@hzoo You are right. I'm missing a space, good catch. I've used template literals, but then I run into "line is too long' warning. But now I discovered that there is line continuation (\) so I'm going to rewrite this.
| @@ -78,7 +78,8 @@ With options: | |||
| { | |||
| "plugins": [ | |||
| ["@babel/transform-react-jsx", { | |||
| "pragma": "dom" // default pragma is React.createElement | |||
| "pragma": "dom", // default pragma is React.createElement | |||
| "throwIfNamespace": false // default throwIfNamespace is true | |||
There was a problem hiding this comment.
I think you can just say defaults to true
|
Awesome, nice work @jukben! 👌 |
Definitely, and very fast and great quality =) |
lock
bot
added
the
outdated
Hi guys 👋 , this is my first attempt to contribute, feel free to correct me, I've tried my best. 💪
I'm not sure about this part, to be honest: https://github.com/babel/babel/pull/6563/files#r147231979
P.S: It seems to that tests on master falling. 😔