Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain plugin order with items in the include option #6663

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #6648
Patch: Bug Fix? n
Major: Breaking Change? y
Minor: New Feature? n
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?

This tweaks behavior in preset-env so that it checks both whether a plugin/builtin is required or the user has it in their includes option as it loops through the (for better or worse) ordered lists.

Plugin ordering can't come soon enough :)

Worth discussing, but this does have the (breaking) side effect that the following is no longer possible:

{
  "modules": false,
  "includes": ["transform-modules-commonjs"]
}

^ seemed sort of weird anyway?

@existentialism existentialism added pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 1, 2017
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 1, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5852/

Copy link
Member

@yavorsky yavorsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@existentialism existentialism merged commit f3fd2ee into babel:master Nov 15, 2017
@existentialism existentialism deleted the issue6648 branch November 15, 2017 16:45
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit return of JSX conflicts with ES7 bind operator
4 participants