Remove core-js/regenerator-runtime stubs #6755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
pkg: polyfill
pkg: preset-env
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5679/ |
|
Context: I believe I originally introduced these because of npm 2 but that is for node 4 and if that's going to be rarer we should just do this, maybe we can provide a better error message but having to maintain a list + this weird module redirection is just weird. |
|
Oh we need to change the readme if you didn't already, not sure if that can be a good first issue or not |
This was referenced Nov 7, 2017
futagoza
added a commit
to futagoza/babel-preset-futagozaryuu
that referenced
this pull request
Nov 15, 2017
Added a script to allow dependencies from `@babel/polyfill` to work on Node.js v4 (see babel/babel#6755)
futagoza
added a commit
to futagoza/babel-preset-futagozaryuu
that referenced
this pull request
Dec 12, 2017
While trying to find a way to let me use `@babel/polyfill: ^7.0.0-beta.32` on Node.js v4 I realised that I would have to do this with every package I create that supports Node.js v4, so I gave up. Thanks babel/babel#6755
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the stubs originally added to eliminate confusion, but I think after much discussion, it wound up being more trouble than it was worth.